search

Tillerino / Tillerinobot

352 stars 112 forks source link

Tillerino not able to connect to api for !u command #185

Closed richp2k closed 4 years ago

richp2k commented 4 years ago

I just noticed this now, but I think this has been happening since the osu!catch SR and pp rework due to osu! api changes. screenshot098

omkelderman commented 4 years ago

that error message is actually a little misleading. When I made that I just reused the error message from other parts of the bot that dealt with osu! API communication.

The !u command however, communicates with the osutrack api, and the osutrack website (https://ameobea.me/osutrack/) has an invalid HTTPS certificate right now, hence why !u is failing atm. It will continue to give that error until the osutrack website gets a valid certificate again.

in short: it has nothing to do with what the error message suggest, it is simply unable to connect to osutrack due to a invalid cert

MrMorkat commented 4 years ago

We might want to change that message then... If i can find the time i will do it tomorrow

omkelderman commented 4 years ago

That's not as easy as you might think, a connection exception is thrown (either in osu api code, or osutrack api code) and when its catched it assumes osu api (since at first that was the only thing it was used for)

Basically at the place where the message text is chosen you can't see if it's an osu api error or osutrack api error)

Tillerino commented 4 years ago

You would throw a UserException where the osu!track API is called, but also need a special message (and translations).

Has the certificate been updated? The website looks fine.

On Sat, Jun 6, 2020 at 1:11 PM Olle Kelderman notifications@github.com wrote:

That's not as easy as you might think, a connection exception is thrown (either in osu api code, or osutrack api code) and when its catched it assumes osu api (since at first that was the only thing it was used for)

Basically at the place where the message text is chosen you can't see if it's an osu api error or osutrack api error)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Tillerino/Tillerinobot/issues/185#issuecomment-640040934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJP2ZIJNRG4IZRUEV2C7FLRVIP75ANCNFSM4NRMH7UQ .

MrMorkat commented 4 years ago

ye ameo fixed it an hour ago or something

Ameobea commented 4 years ago

Yeah sorry about that - this was a while ago and I've set up an auto-update script for my certs going forward.

Tillerino commented 4 years ago

No harm done. They're all free services :)

And we should have closed this a while ago, I guess