search

TilmanNeumann / java-math-library

A Java math library focused on number theory and integer factorization in particular.
GNU General Public License v3.0
30 stars 7 forks source link

ToDelete #13

Closed Pascal66 closed 5 years ago

Pascal66 commented 5 years ago

Use TDPrimeTest.getInstance() instead of new TDprimeTest()

PrPTest and BPSWTest for example avoid initialization when not needed

Pascal66 commented 5 years ago

Singleton as from the olders (wrong) patch I've submited.

Cosmectics Not changing anything of original work (no improvment or else) Only declaration of arraylist are changed to be conform (Interface instead class)

TilmanNeumann commented 5 years ago

I have a problem with this PR. The diff has several thousand of lines and I can not review it in a reasonable time.

For a start, I'ld like to ask you for the relevant changes only (without "cosmetics")

Or could I accept only some of your commits? (my git(hub) knowledge is limited)

Pascal66 commented 5 years ago

I'll try :) (Uniformize ArrayList to List modifie allmost 90 files)

TilmanNeumann commented 5 years ago

Are you working with Eclipse? If, then how do I apply "uniformize"? I didn't find that yet.