search

Tim-B / grunt-aws-lambda

A grunt plugin to assist in developing functions for AWS Lambda.
MIT License
247 stars 100 forks source link

How to set runtime in lambda_deploy? #105

Open samstrickler opened 7 years ago

samstrickler commented 7 years ago

How do you set the runtime variable during deploy? Is it enabled as an option? If supported can you please provide an example.

haylingsailor commented 7 years ago

I wanted this too, but it wasn't supported, so I've added a PR#107 https://github.com/Tim-B/grunt-aws-lambda/pull/107. That's failing right now but not on the additions I made. When I forked the repo and ran the tests, one test was failing (dateFacade.getHumanReadableTimestamp was returning a different format) so I fixed it before submitting the PR, but that test is now failing on Travis. That function just returns .toLocaleString() so presumably that gives a different answer on the CI setup. It's odd, because the docs for toLocaleString() say it should give the format I put in the test...

haylingsailor commented 7 years ago

PR now passes tests...