SVG Support - Githubissues

TimBeyer / html-to-vdom

Converts an HTML string into a virtual DOM

172 stars 41 forks source link

SVG Support #27

Open shaunpatterson opened 8 years ago

shaunpatterson commented 8 years ago

Incorporates https://github.com/TimBeyer/html-to-vdom/pull/22

Added a few extra tests for more code coverage

TimBeyer commented 8 years ago

Hey, thanks a lot for the extended PR.
What I'm really missing to finally merge the SVG support is to follow the more modular structure I introduced in https://github.com/TimBeyer/html-to-vdom/pull/21

Currently the SVG handling is kind of a regression code-wise, at the same time leaving the modules lying around as orphaned code.

Once that is taken care of I'll gladly merge this.

TimBeyer commented 8 years ago

Hey @spattersongt, sorry I never got back to you. To be honest, I just never noticed you pushed some additional commits.

I promise I'll review this in the coming days. Your contribution is much appreciated :)

feelic commented 8 years ago

This would be awesome to have, is there anything I could do to help with it ?

coveralls commented 8 years ago

Coverage decreased (-5.2%) to 94.764% when pulling 0a4d5ec55cf4c60d18938e80fa724bb19d7c31fa on spattersongt:master into 42c1229bb18f7cc1819b9c5c679cec4caa8f8094 on TimBeyer:master.

coveralls commented 8 years ago

Coverage decreased (-5.2%) to 94.764% when pulling 0a4d5ec55cf4c60d18938e80fa724bb19d7c31fa on spattersongt:master into 42c1229bb18f7cc1819b9c5c679cec4caa8f8094 on TimBeyer:master.

Jarred-Sumner commented 8 years ago

Something I'm working on depends on inline SVG support, and I'd love to use this library. What are the next steps on this PR?

jxm262 commented 7 years ago

👍 Chiming in along with the other commenters, is there any plans to merge this? Or if there's still specific issues with the PR, is there anything I can do to help?

For the meantime I'm going to use the fork from @shaunpatterson

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling e65af81ee26dd619caf30c5a14512d0b91cf359e on shaunpatterson:master into 42c1229bb18f7cc1819b9c5c679cec4caa8f8094 on TimBeyer:master.