Cleanups - Githubissues

TimDaub / jsonresume-theme-paper

A theme for JSON Resume

36 stars 56 forks source link

Cleanups #5

Closed ajyoon closed 8 years ago

ajyoon commented 8 years ago

Fixes massive whitespace damage throughout the sources and adds some comments in index.js.

Visible changes:

The rendering of work listings is a little more flexible and now renders correctly if the company field is omitted (useful for freelance positions). For example, where an empty company field with a position field of 'Freelance Front-End Dev' previously would have rendered something like "Freelance Front-End Dev at :", it now renders simply as "Freelance Front-End Dev:" The relevant modifications are in resume.template at the (new version) lines 169 and 172
The header picture no longer has title "Wiggle Wiggle"

Cheers!

TimDaub commented 8 years ago

Hey, thank you so much :) I'll take a look later!

ajyoon commented 8 years ago

It's worth mentioning that NPM is slightly behind master (by one commit I think?), and I originally worked on this code from NPM, so there may be some tiny regressions hiding here. I'm going to do a thorough look-over again as well to make sure that's not the case. The whitespace damage was so bad that the diff has trouble aligning things unfortunately.

ajyoon commented 8 years ago

One change I just caught which I forgot to mention:

The header picture no longer has title "Wiggle Wiggle"

I'm happy to revert this if you want.

ajyoon commented 8 years ago

Pinging @TimDaub - any update on this?

TimDaub commented 8 years ago

Hi,

first of all sorry for the huge delay. I added reviewing this to my calendar weeks ago. Must have missed the notification :(

Anyways,

I checked out the changes and also ran them on my machine. Works perfectly.

Thank you so much for fixing this!

TimDaub commented 8 years ago

Published new version on npm.