TimFinucane / Ainur

Solution for parallel task scheduling problem, inspired by the tale of the Lord of the Rings
Other
5 stars 0 forks source link

Io/reader #11

Closed Buster-Darragh-Major closed 6 years ago

Buster-Darragh-Major commented 6 years ago

@maddiebeagley oh whoops forgot to put that in

TimFinucane commented 6 years ago

What is the purpose of testTextWithNoise? Edit: Oh wait I think i understand. Another potential option for allowing noise is to change your edge and node lookbehind regex sections to look for either a '{' (for a graph opening) or ';' (for a previous statement ending), which adheres to the dot format syntax.

emipeanz commented 6 years ago

+1 to commenting the regex. Only issue I see is if lecturer decided to throw us curve ball with node labels, but I think that's on our to-do list. Other than that, all good 👍 👍 :) I might be missing something, but if he hands in the 'graph' (tasks to be processed) as a file name, does the reader open the file and go from there, or does main or whatever's calling DotGraphReader read the file first, then give the input stream to reader??

Buster-Darragh-Major commented 6 years ago

@TimFinucane good idea i'll get that implemented later today, @emipeanz we have discussed this in person 💯 💯