search

TimFinucane / Ainur

Solution for parallel task scheduling problem, inspired by the tale of the Lord of the Rings
Other
5 stars 0 forks source link

Implemented Common Model #3

Closed maddiebeagley closed 6 years ago

maddiebeagley commented 6 years ago

Implemented underlying model for code base.

nathan-cairns commented 6 years ago

@TimFinucane Re The algorithm class. According to the UML the methods left non-abstract should be implemented in the Parent. If made abstract we will have to implement in the children i.e DFSAlgorithm. Do we want this?

maddiebeagley commented 6 years ago

Upon reflection, Nathan and I think we should generate Graphs using a constructor that takes in Nodes and Edges as opposed to passing around more complex types just for the sake of assigning the construction to the Graph class. We are of the opinion that construction of Edges and Nodes should be a responsibility of the GraphReader class.

Have made changes to the Graph class that are relevant to your other points :)

nathan-cairns commented 6 years ago

@TimFinucane javafx build thingy should be removed now

TimFinucane commented 6 years ago

Yup all looks good now, and @Nathan-Cairns I concede to your point with Algorithm abstractions.

I will note that I would prefer a solution that would somehow keep building of the graph from it's base components internal to the graph class, however am fine with this as an alternative