search

TimGeyssens / BundlingAndMinificationForTheMasses

UI layer on top of http://aspnetoptimization.codeplex.com/ for Umbraco
http://www.nibble.be/?p=237
25 stars 5 forks source link

Style of labels for each providers #11

Open bjarnef opened 8 years ago

bjarnef commented 8 years ago

I have installed Optimus 1.4.0 in Umbraco 7.4.1 ... and after install it suggest to install providers.

image

I Umbraco 7.4.0 the labels seems to have changed style, so by default they use display: block; ... so you might want to use display:inline-block; instead.

bjarnef commented 8 years ago

I have created an issue here instead: http://issues.umbraco.org/issue/U4-8058

I think it should be changed in Umbraco since it affect styling of many packages and <label> as default is an inline element.

bjarnef commented 8 years ago

I noticed a other minor thing: When installing a provider, the provider use umb-loader, but it is causing horizontal scrollbar while loading because of horizontal overflow.

It was an issue in earlier versions of Umbraco 7, but I made a PR for that: https://github.com/umbraco/Umbraco-CMS/pull/477

so by wrapping the loader with <div class="umb-loader-wrapper"></div> it hides overflow - you can inspect the DOM find package installer to compare.

https://github.com/umbraco/Umbraco-CMS/blob/2aa5dfb3ec50f4ddbd23c1fef24d00a6281b3fe9/src/Umbraco.Web.UI/umbraco/developer/Packages/installer.aspx#L78-L80