search

TimGeyssens / Umbraco-v8-Community-Website-StarterKit

The goal of this repo is to have a community managed starter project/kit for #umbraco v8 following the best practices and showcasing nice tips and tricks
https://dev.to/timgeyssens/how-to-join-the-fun-and-get-started-with-contributing-to-the-umbraco-community-starter-project-kit-36gn
MIT License
18 stars 12 forks source link

Bring tabs in the mix #50

Closed TimGeyssens closed 3 years ago

TimGeyssens commented 3 years ago

Install Matryoshka https://our.umbraco.com/packages/backoffice-extensions/matryoshka-tabs-for-umbraco-8/ (with nuget)

prgriffithsdev commented 3 years ago

Hey Tim, ill add this package (Our.Umbraco.Matryoshka -Version 0.5.0) so I can implement and get a feel for the process to check-in and create a PR. I have the repo forked, cloned, running locally, and imported in uSync. Let me know the instructions e.g. do I work on main or create a feature\bugfix branch, creating a PR, any conventions to the commit message, etc. and ill get this added to ensure I can complete the pipeline correctly - am I able to assign this task to myself to avoid crossover with other contributors?

TimGeyssens commented 3 years ago

hey @prgriffithsdev awesome! Just comming and push to the main branch of your fork... then you can create pr with the github ui.

I'll check if I can open up the assignees bit... for now maybe just leave a comment... that you are handling this 👍

prgriffithsdev commented 3 years ago

Cool, that's the PR all done and hopefully, it's correct, I've not contributed before :)

TimGeyssens commented 3 years ago

It is perfect :) thanks! And I think you just earned the Umbraco swag :)

prgriffithsdev commented 3 years ago

Thanks, Tim, ill look through the issue list and see what else I can do. #onaroll