TimHeckel / meteor-bootboxjs

A meteor smart package for the bootstrap bootboxjs plugin
30 stars 19 forks source link

cleanup and update to 4.2.0 #12

Closed mizzao closed 10 years ago

mizzao commented 10 years ago

This PR updates bootbox to 4.2.0 and does some additional cleanup:

mizzao commented 10 years ago

Dear @TimHeckel, I hope you can merge this in a timely manner so that we can prevent the pollution of our lovely Atmosphere.

If you are too busy, I understand - I'd be happy to maintain this repository for you if you would just add me as a collaborator and give me permission to publish to bootboxjs on Atmosphere. You can check out my profile for my Meteor smart package creds :)

TimHeckel commented 10 years ago

Andrew, this is awesome. Thanks. I really appreciate it. You're also a collaborator, so feel free to help maintain. As you can tell, it's been quite neglected :)

mizzao commented 10 years ago

Thanks, @TimHeckel!

It would be really helpful if you would add me as a maintainer on Atmosphere as well so that I could release updated versions of this package. Then I could close all those other issues as well.

See https://atmosphere.meteor.com/wtf/maintain where mizzao is my username and bootboxjs is your package name.

mizzao commented 10 years ago

Hey @tmeasday, would you mind adding me as a maintainer to this package? (citing the above for permission). Not sure when Tim's going to get around to it and currently getting Error: That ain't yr package son! :-)

tmeasday commented 10 years ago

@mizzao - let's give @TimHeckel until the end of the weekend to do it -- feels a bit rude otherwise :)

mizzao commented 10 years ago

Okay. I blame it on my compulsive urge to tag new package releases and close issues...

tmeasday commented 10 years ago

Not a bad urge to have...

TimHeckel commented 10 years ago

Andrew -- you're all set. Thanks for your initiative and willingness to help. If you run across any other of my ill-maintained packages and would like to help, I'm happy to add you to those as well. I've been (as we all are I'm sure) swamped with work. Thanks so much.

Tim

PS, Tom -- I already said congrats to Zol, but huge props to you and Percolate for Atmosphere. I LOVE the design.

PPS, I am not sure how to confirm, but I did log into atmosphere Meteor.loginWithPassword, and then I ran the below: Meteor.call('addPackageMaintainer', 'bootboxjs', 'mizzao')

On Sun, Apr 6, 2014 at 8:59 PM, Tom Coleman notifications@github.comwrote:

Not a bad urge to have...

Reply to this email directly or view it on GitHubhttps://github.com/TimHeckel/meteor-bootboxjs/pull/12#issuecomment-39690722 .

mizzao commented 10 years ago

You're welcome! Thanks for being willing to deal with my pesky requests :)

You should consider adding some Gittip (https://www.gittip.com/for/meteor/) links to your repos to help with maintenance:)

tmeasday commented 10 years ago

Thanks @TimHeckel !