search

TimHeckel / meteor-bootboxjs

A meteor smart package for the bootstrap bootboxjs plugin
30 stars 19 forks source link

Custom Dialogs don't work #5

Closed davidworkman9 closed 10 years ago

davidworkman9 commented 10 years ago

Out of the box custom dialogs don't work. Lib should probably be upgraded to 4.0.0 as this fixed my issues.

mizzao commented 10 years ago

@davidworkman9 Is this because you are using Bootstrap 3? That may be the reason, because 3.2.2 only works with Bootstrap 2.

davidworkman9 commented 10 years ago

Probably. I just include 4.0.0 in my lib folder now instead of using the package.

mizzao commented 10 years ago

That would be nice, except packages that use bootbox can't depend on that behavior.

Namely: https://github.com/mizzao/meteor-tutorials

davidworkman9 commented 10 years ago

True. We need some sort of system to keep these wrapper modules up to date/only one of them

davidworkman9 commented 10 years ago

Looking at the date I posted this and my git commit history I wasn't on bootstrap 3 when I posted this. Are you having the same issue @mizzao ?

mizzao commented 10 years ago

You were probably using Bootbox 4 with Bootstrap 2 then.

davidworkman9 commented 10 years ago

Nope as I said in my original message at the top here upgrading to 4.0.0 fixed my problems. Either way I don't think it's very important 6 months later.. It looks like the maintainer has upgraded to 4.1

mizzao commented 10 years ago

I just opened a PR to update and clean up this package a bit in #12.