search

TimLariviere / Fabulous-new

Fabulous v2 - Work in progress
https://timothelariviere.com/Fabulous-new/
Other
41 stars 3 forks source link

[Bug] Investigate bugs when diffing NavigationPage #100

Closed TimLariviere closed 2 years ago

TimLariviere commented 2 years ago

TDB

edgarfgp commented 2 years ago 
System.ArgumentException: The index was outside the range of elements in the list.
Parameter name: n  at Fabulous.XamarinForms.ViewUpdaters.applyDiffNavigationPagePages

Similar to what we saw in https://github.com/TimLariviere/Fabulous-new/pull/105

TimLariviere commented 2 years ago

I fixed an out of range issue in #111

Now applyDiffNavigationPagePages doesn't use the Pages.Length anymore (because it's not updated until after the pop/push animation played). This should prevent Out of Range exception from happening.

Could you check if it's good for you?

edgarfgp commented 2 years ago

@TimLariviere I can confirm this is not longer an issue when navigating.