Fix android samples - Githubissues

TimLariviere / Fabulous-new

Fabulous v2 - Work in progress

https://timothelariviere.com/Fabulous-new/

Other

41 stars 3 forks source link

Fix android samples #44

Closed edgarfgp closed 2 years ago

edgarfgp commented 2 years ago

This Pr introduces fixes for the android samples:

In order to make the samples work on android I had to:

Create the android project using the fabulous-cli as the previous one was not generating the needed files and dependencies to be compatible with FormsAppCompatActivity
Also Migrated the android samples to use PackageReferences so I could diagnose what was wrong with the android x versions
I had to Update the ContactsListPage on the ContactsApp to be able to build the app with net 5

CounterApp is building and running ContactsApp is building WeatherApp is building and running TicTacToe is building and running

edgarfgp commented 2 years ago

If you are happy with the changes we can close #6

edgarfgp commented 2 years ago

Awesome . Thanks 😀. Let me know if there is anything more I can help

TimLariviere commented 2 years ago

I'm extremely surprised (and happy) to see that now we have PackageReference working in old style fsproj. Sooo much easier to work with. Thanks @edgarfgp for making me notice it with your PR 🥳

Edit: yeah no, nothing changed. Only VS Windows doesn't support PackageReference in old fsproj...

edgarfgp commented 2 years ago

Yeah I’m using a Mac and Rider and works fine with PackageReferences

edgarfgp commented 2 years ago

I raised an issue sometime ago in the main repo . So maybe we can improve the samples and the templates also there https://github.com/fsprojects/Fabulous/issues/896

TimLariviere commented 2 years ago

So maybe we can improve the samples and the templates also there

I prefer not to. Like I said, PackageReference in old-style fsproj is not supported by Visual Studio Windows, so changing the samples and templates for v1 will break a lot of people.

Here in v2, I feel it's okay because we will use net6.0-ios and net6.0-android sooner or later. In the meantime, we're not compatible with VS Windows.

edgarfgp commented 2 years ago

Yeah you are right . Do you know if Rider in windows supports PackageReference ?. that might be an alternative . I really surprise. that VS for windows does not support that given that is a MSFT flag ship IDE 😄. Maybe VS 2022 supports it now .

TimLariviere commented 2 years ago

Rider supports PackageReference on Windows (even MSBuild supports it...) because it's the same app on all platforms. But it is not as widely used by .NET developers since it is a paid IDE (usually not provided by the company).

VS 2022 is the same. It doesn't support PackageRef because Microsoft didn't wanted to invest time in this feature, since new sdk-style projects were supposed to replace old style completely.

See discussion here: https://github.com/dotnet/fsharp/issues/5849