CarrouselView + IndicatorView

TimLariviere / Fabulous-new

Fabulous v2 - Work in progress

https://timothelariviere.com/Fabulous-new/

Other

41 stars 3 forks source link

CarrouselView + IndicatorView #66

Closed edgarfgp closed 2 years ago

edgarfgp commented 2 years ago

This Draft attempt tp implement the CarrouselView + IndicatorView and the intecation between them :

Implemented :

CarrouselView Builder using virtualised collection like CollectionView
Initial IndicatorView WIP

NOT Implemented :

IndicatorView that can use ItemSource that the CarrouselView to match the number elements show on the Indicator
IndicatorView PositionChanged events that sync the CarrouselView position changed

TimLariviere commented 2 years ago

CarouselView is buggy and doesn't trigger the PositionChanged event, nor scroll when receiving a new position

edgarfgp commented 2 years ago

@TimLariviere Would creating a FabulousCarrouselview and force PositionChanged event to trigger will help ?

edgarfgp commented 2 years ago

Hum I see what do you mean . I tried this morning and same result. I think we need to ViewRef like in V1 to make this usable 😔

TimLariviere commented 2 years ago

We can try to figure out the bug and work around it. I would really prefer not using ViewRef...

edgarfgp commented 2 years ago

@TimLariviere In order make some progress . Would you consider merging only the Controls in isolation and then open an issue to tackle the Bug in another PR ?

TimLariviere commented 2 years ago

Would you consider merging only the Controls in isolation and then open an issue to tackle the Bug in another PR ?

I guess we can merge this PR like that for now. The "public" API will not change. It's really the underlying controls (or the way Fabulous interacts with it) the problem.

If you could fix the merge conflict and make the PR build pass, I will approve it

edgarfgp commented 2 years ago

Rebase done. 'm going to check the docs to see if there is any extension missing and then set this as proper PR