search

TimOliver / TOPasscodeViewController

A modal passcode input and validation view controller for iOS
MIT License
387 stars 96 forks source link

Posible improvements #16

Open lukeleleh opened 6 years ago

lukeleleh commented 6 years ago

Hardware / Software

Which version of the library were you using? 0.0.1 Which version of iOS are you running? iOS 11 What model of iOS device were you testing on? iPhone 8 If using CocoaPods, which version of CocoaPods are you on? 1.3.1

Goals

What is the outcome result you want to achieve with this library?

Provide the possibility to lock an app.

Expected Results

What did you expect to happen?

A) Provide a cancel button in TOPasscodeSettingsViewController. It could be an optional like rightAccessoryButton in TOPasscodeViewController. B) Provide a property to hide the options button in TOPasscodeSettingsViewController to limit the passcodeType. C) A way to change the text from views for translation.

Actual Results

What happened instead? (Please attach a screenshot/screen recording if possible)

Steps to Reproduce

What are the steps needed to reproduce this issue? If this bug was caused by a specific image, please post it here.

It's not a bug 😄.

Thank you for this great library!

TimOliver commented 6 years ago

Thanks for the issue @LukA888! I'm glad you're enjoying the library!

Yeah! Those suggestions sound good! I doubt they'd be very hard to add. If you or anyone else would like to add it in a PR, I'd really appreciate it. :)