search

TimOliver / TOPasscodeViewController

A modal passcode input and validation view controller for iOS
MIT License
387 stars 96 forks source link

Fix theming setters for TOPasscodeView #22

Closed MacroYau closed 5 years ago

TimOliver commented 6 years ago

Thanks for the PR! Hmm, a lot of those probably don't need instance variables in TOPasscodeView itself, you could probably just directly link them to the properties they're controlling in the various subviews. :)

MacroYau commented 6 years ago

My original thought was that the custom theming would be overridden when applyThemeForStyle:style is invoked, if I do not assign them to those existing instance variables in TOPasscodeView.h. What do you think?

TimOliver commented 5 years ago

Hi @MacroYau!

I am so so sorry! I was so busy last year that this issue slipped my mind until now.

I just reviewed the code in more detail, and it looks like you're right. Keeping instance variables to avoid the theme resetting is a better idea.

Thanks so much for the PR!