TimOliver / TOPasscodeViewController

A modal passcode input and validation view controller for iOS
MIT License
387 stars 96 forks source link

Error on installation via Carthage #40

Open ARGAMX opened 4 years ago

ARGAMX commented 4 years ago

Cartfile:

github "TimOliver/TOPasscodeViewController"

Terminal:

iMac:App-iOS-Sources user$ carthage update --platform iOS --no-use-binaries Cloning TOPasscodeViewController Checking out TOPasscodeViewController at "0.0.2" xcodebuild output can be found in /var/folders/nb/9g4bcynn1bbbl93rrd7nns4h0000gn/T/carthage-xcodebuild.Hj36cs.log Skipped building TOPasscodeViewController due to the error: Dependency "TOPasscodeViewController" has no shared framework schemes for any of the platforms: iOS If you believe this to be an error, please file an issue with the maintainers at https://github.com/TimOliver/TOPasscodeViewController/issues/new

How to fix this Error? I have 17 plugins from GitHub installed in the iOS project via Carthage. I want to install TOPasscodeViewController as a 18 plugin, but getting this Error. Thanks.

Seems that fremework don't support Carthage yet. But seems adding Carthage support is quite easy task:

https://amerhukic.com/how-to-add-carthage-support-in-existing-cocoapod-project

https://webcache.googleusercontent.com/search?q=cache:gNv43se4RWIJ:https://amerhukic.com/how-to-add-carthage-support-in-existing-cocoapod-project

https://github.com/Carthage/Carthage#share-your-xcode-schemes

TimOliver commented 4 years ago

Hi @ARGAMX!

Thanks for the issue! I haven't officially added Carthage support to this project yet. I'm working on some other stuff now, and this library, given that it's not being accepted by Apple right now is low priority for me.

I'm working on refining my CI release script to automatically build and deploy Carthage compatible frameworks, so I'll be looking at that soon. :)

In the meantime, if you want to add Carthage support, please feel free to file a PR. :)

Thanks!

ARGAMX commented 4 years ago

In the meantime, if you want to add Carthage support, please feel free to file a PR. :)

Ok, thanks.

I have made PR. Works OK for me, I have successfully build TOPasscodeViewController.framework

https://github.com/TimOliver/TOPasscodeViewController/pull/42