search

TimOliver / TOPasscodeViewController

A modal passcode input and validation view controller for iOS
MIT License
385 stars 96 forks source link

Feature Request: Way to Turn Passcode Off Using TOPasscodeSettingsViewController #9

Open inPhilly opened 6 years ago

inPhilly commented 6 years ago

Hardware / Software

Which version of the library were you using?0.0.1 Which version of iOS are you running?several in simulator What model of iOS device were you testing on?several in simulator If using CocoaPods, which version of CocoaPods are you on?N/A

Goals

What is the outcome result you want to achieve with this library? Passcode controller in my app

Expected Results

A TOPasscodeSettingsViewState option to turn passcode off

Actual Results

It seems like, as of now, the TOPasscodeSettingsViewController can only be used to turn passcode on or change passcode. Usually, it is required that a user confirm a passcode before setting it off, and I could not see a way to easily do that with the controller as-is.

These are the current allowable states: typedef NS_ENUM(NSInteger, TOPasscodeSettingsViewState) { TOPasscodeSettingsViewStateEnterCurrentPasscode, TOPasscodeSettingsViewStateEnterNewPasscode, TOPasscodeSettingsViewStateConfirmNewPasscode };

Feature Request

Add a way to turn passcode off, after confirmation of current passcode, using TOPasscodeSettingsViewController.

TimOliver commented 6 years ago

Sounds good! I'll probably have to implement this by the time I get around to integrating it into my own app, but if anyone else needs it before then, a PR would be greatly appreciated. :)