search

TimOliver / TOWebViewController

A view controller class for iOS that allows users to view web pages directly within an app.
http://www.timoliver.com.au/2014/07/27/towebviewcontroller-an-open-source-web-viewer-for-ios/
Other
1.48k stars 211 forks source link

toolbarItems not visible when presented in UIPageViewController #113

Open hllGitHub opened 7 years ago

hllGitHub commented 7 years ago

Thanks for considering filing an issue! Before proceeding, please consider the type of issue you're filing and make sure to supply the proper details needed for it! :)

Questions: Please check the closed issues to see if it's already been asked before.

Feature Request: Please fill in just the first two sections. Please be as thorough as possible and explain how you would expect this feature to work both visually, and from an API perspective.

Bugs: Please be as thorough as possible when describing the bug you've discovered. If it's a UI bug, please attach a screenshot. If it's an animation bug, please provide a video recording of the bug in action.

Please note that since library is done as a side-project outside of work hours, a timely response cannot be guaranteed. ;)

Please remove this line and everything above it before submitting.

Goals

What was the outcome result you wanted to achieve when using this library?

Expected Results

What did you expect to happen?

Actual Results

What actually happened instead? (Please attach a screenshot/screen recording if possible)

Steps to Reproduce

What are the steps needed to reproduce this issue? If this bug was caused by a specific URL, please provide it here.

Hardware / Software

On which version of iOS, and what model of device did you experience this bug?

It is good to use it under normal circumstances. But when I use UIPageViewController, the toolbarItems is gone. TOWebViewController as viewControllers. image ![2017-05-10 4 22 51]

TimOliver commented 7 years ago

Hi there!

Hmm, a UIPageViewController? I've never tested it in that before. Do you have a sample app that you could upload here for me to test?

I don't really have time to add new features (This controller was only designed to be pushed modally, or in a UINavigationController, not in anything else), so a PR here would be mighty appreciated. :)