search

TimOliver / TOWebViewController

A view controller class for iOS that allows users to view web pages directly within an app.
http://www.timoliver.com.au/2014/07/27/towebviewcontroller-an-open-source-web-viewer-for-ios/
Other
1.48k stars 211 forks source link

2.2.7 UI Error on iOS 11 #125

Closed klaus01 closed 6 years ago

klaus01 commented 6 years ago

Expected Results

UI display correctly.

Actual Results

WebView.top displays an error in the ViewController of the non-transparent navigation bar.

Steps to Reproduce

UINavigationBar.appearance().isTranslucent = false

let vc = TOWebViewController(urlString: urlString)!
self.navigationController?.pushViewController(vc, animated: true)
wx20180322-203731 2x

Hardware / Software

TOWebViewController 2.2.7 iOS 11

Fix

fix
Bretra commented 6 years ago

its very good

TimOliver commented 6 years ago

Thanks for the thorough issue @klaus01!

I just refactored the code to handle iOS 11 scroll views better. Can you please test it and see if that's fixed it?

Thanks!

ducbm051291 commented 6 years ago

In my project, somehow after web loaded the content Inset top is not 0 so I have to set it back to 0

simulator screen shot - iphone x - 2018-07-25 at 14 23 44

TimOliver commented 6 years ago

Haver you tried it on the version I released yesterday?

TimOliver commented 6 years ago

Since I've removed that offending block of code, I think this should be fixed now.

Please open a new issue with a URL I can test if not. :)