TimOliver / TOWebViewController

A view controller class for iOS that allows users to view web pages directly within an app.
http://www.timoliver.com.au/2014/07/27/towebviewcontroller-an-open-source-web-viewer-for-ios/
Other
1.48k stars 211 forks source link

Conflict with any localization in the main app. #39

Closed kjanusz closed 9 years ago

kjanusz commented 10 years ago

When using TOWebViewController via CocoaPods, the lproj directories are copied to the root of the main bundle. This causes two issues:

1) They conflict with any localization in the main app. 2) The App Store detects these localized bundles and assumes the app is fully localized into all 6 languages TOWebViewController supports (de, en, es, ja, ko, pl, ..). We only support German.

This is a real problem. I think best idea for pods is to use ressource_bundles instead of resources. http://guides.cocoapods.org/syntax/podspec.html#resource_bundles

TimOliver commented 9 years ago

Sorry for the late reply! I've been dealing with the latest update of one of my apps and am catching up on my backlog now.

Oh dear! I had no idea the lproj was being included! Thanks for that! I'll see about modifying the podspec to include only the proper files.

-Tim

On 8 November 2014 at 01:03, kjanusz notifications@github.com wrote:

When using TOWebViewController via CocoaPods, the lproj directories are copied to the root of the main bundle. This causes two issues:

1) They conflict with any localization in the main app. 2) The App Store detects these localized bundles and assumes the app is fully localized into all 6 languages TOWebViewController supports (de, en, es, ja, ko, pl, ..). We only support German.

This is a real problem. I think best idea for pods is to use ressource_bundles instead of resources. http://guides.cocoapods.org/syntax/podspec.html#resource_bundles

— Reply to this email directly or view it on GitHub https://github.com/TimOliver/TOWebViewController/issues/39.

TimOliver commented 9 years ago

Switched over to bundle_resources! Hopefully that took care of that! :)