search

TimOliver / TOWebViewController

A view controller class for iOS that allows users to view web pages directly within an app.
http://www.timoliver.com.au/2014/07/27/towebviewcontroller-an-open-source-web-viewer-for-ios/
Other
1.48k stars 211 forks source link

Feature/Add doneButtonTintColor feature and small example #95

Closed OEA closed 8 years ago

OEA commented 8 years ago

Added small feature to customize just done button tint color.

TimOliver commented 8 years ago

Thanks for the PR, Ömer!

I had a look at it and had a bit of feedback. At the moment, since it doesn't let the Done button defer back to the normal buttonTintColor property, this would break the existing functionality of the controller. I left some notes; please review and update your PR. :)

Thanks!

OEA commented 8 years ago

Hey Tim,

First of all thank you for your answers. I saw your comments and thank you for your kind answers.

1) You are right it is not necessary but I always override the setter method :) 2) It is not necessary to check that it is nill or not because when you set the tint color as nil, it won't break the code because you alread initialized the self.donebutton with .UIBarButtonItemStyleDone 3) I think your comment will be better than I wrote 4) I will update the code :)

Thank you for your interest. I really like to use your framework.

TimOliver commented 8 years ago

This PR has been pending for nearly a month now without the changes I requested being addressed, so I'm going to close it off.

Feel free to re-open it once the changes are addressed and the merge conflicts are resolved. :)