search

TimPietrusky / background-clip-text-polyfill

A SVG polyfill for -webkit-background-clip: text
132 stars 30 forks source link

Remove patternID #4

Closed christianbundy closed 7 years ago

christianbundy commented 10 years ago

I don't think that there's a use-case for the patternID property, since you can easily use the polyfill on multiple unique elements that share a class by using the polyfill method only on the element that you want it active on.

I think that the patternID was a great idea for making sure that the polyfill is only active when it's supposed to be, but since element.backgroundClipPolyfill() only runs on element, it's safe to remove without any side-effects.

This pull request is also backward compatible, as long as the old version doesn't run the method on elements that aren't supposed to be polyfilled (which isn't the intended use for this anyway).

christianbundy commented 9 years ago

@TimPietrusky do you need anything from me to merge this PR?

christianbundy commented 7 years ago

Should this be closed?