TimPietrusky / weloveiconfonts

This is like Google Web Fonts, but for Open Source Icon Fonts. Hurray!
https://weloveiconfonts.com
652 stars 99 forks source link

Specify charset rule in css, please. When not present, lead to render errors #36

Closed soulchainer closed 10 years ago

soulchainer commented 11 years ago

http://www.w3.org/TR/css3-syntax/ , point 3th. You don't specify any charset in css files. And this throw an error when you test your page with the mobile validator (http://validator.w3.org/mobile/).

"One of the resources required to render the page (most likely a CSS style sheet) does not declare its encoding as UTF-8 in an HTTP Content-Type header. Check that its content is properly encoded, and consider declaring its encoding at the HTTP level"

If this were the unique effect, i won't care about it, but, because of that, there are errors in certain mobile browsers (at least), that affects to certains font icons, delivering that very well known and pretty rhombus with a question mark inside. A image example from Dolphin Browser, where the entypo-link icon fails: http://dl.dropbox.com/u/11008160/screens/SC20130210-132126.png

I think that this should be easy solved by following the css3-syntax and adding a @charset "UTF-8"; (or the proper encoding) in the first line of the css that weloveiconfonts serves.

Like curiosity: google web fonts fails on the same point (I will try to send to it the same message, hoping to be listened :p).

And that's all. Thanks for your GREAT work. I really love weloveiconfonts (yeah: pun intended :D).

marcop135 commented 11 years ago

Interesting...but your dropbox link is broken.

TimPietrusky commented 10 years ago

I added the correct syntax which is @charset "UTF-8" according to http://www.w3.org/TR/CSS2/syndata.html#charset