search

TimSoethout / goodwe-sems-home-assistant

Sensor for Home Assistant pulling data from the GoodWe SEMS API for solar panel production metrics.
88 stars 37 forks source link

brand logo #83

Open Arrheniu2 opened 1 year ago

Arrheniu2 commented 1 year ago

Hi, im not sure if is an issue but we cant see the brand sems logo in the integration, maybe we can add it to the home assistants brand logo repositore?

not sure if we can pull that logo there to the domain "sems" or maybe we should host locally or add to this repositore

TimSoethout commented 1 year ago

Great idea. Feel free to make a pull request with the required changes. :)

28 Mar 2023 11:13:03 Arrheniu2 @.***>:

Hi, im not sure if is an issue but we cant see the brand sems logo in the integration, maybe we can add it to the home assistants brand logo repositore?

not sure if we can pull that logo there to the domain "sems" or maybe we should host locally or add to this repositore

— Reply to this email directly, view it on GitHub[https://github.com/TimSoethout/goodwe-sems-home-assistant/issues/83], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAEQZ3F5GWGDOCSNNZCJ4FTW6KTQ5ANCNFSM6AAAAAAWKIWDSQ]. You are receiving this because you are subscribed to this thread.[Tracking image][https://github.com/notifications/beacon/AAEQZ3CLC7RKC6MTW5NHMLLW6KTQ5A5CNFSM6AAAAAAWKIWDSSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGD5RTMI.gif]

Arrheniu2 commented 1 year ago

i made my first github pull request here: https://github.com/home-assistant/brands/pull/4251

probably i messed up something but eventually we will get the logo in home assistant (i hope)

thanks for your work, tho. regards

f00f commented 11 months ago

I guess you should resubmit that PR with the new Goodwe brand logo which is now a red stylized letter 'W'.