search

TimSoethout / goodwe-sems-home-assistant

Sensor for Home Assistant pulling data from the GoodWe SEMS API for solar panel production metrics.
88 stars 37 forks source link

Feedback on moving from extra_state_attributes to sensors. #89

Open L-four opened 11 months ago

L-four commented 11 months ago

I have been working on a branch which exposes API data as Sensors rather then extra_state_attributes on the inverter entity. Is allows us to tell home assistant about the types of the attributes.

Here's where I currently stand in this development https://github.com/L-four/goodwe-sems-home-assistant/blob/master/custom_components/sems/sensor.py

I would like to gauge interest merging this change and gathering feedback on these changes.

Screenshots:

image image
TimSoethout commented 11 months ago

Really nice work. I think it would definitely make the component more future proof! Also it makes access to the different attributes as sensors a lot nicer than using templates.

Maybe a next step would be to make a PR and iterate in there, or put it on a branch here, so we can make a beta release at least.

f00f commented 11 months ago

Yeah, individual sensors would be awesome. I'm a noob with HA, but I could help with testing this anyways - if someone tells me how to install a dev branch of this integration.

robinhood-code commented 11 months ago

this is nice. hope it will be merged soon.

f00f commented 11 months ago

@TimSoethout created a PR from this: https://github.com/TimSoethout/goodwe-sems-home-assistant/pull/91