search

TimSong412 / 2D-surfel-gaussian

GNU General Public License v3.0
153 stars 6 forks source link

discussion about how to compute AABB and center point #13

Open CanCanZeng opened 1 month ago

CanCanZeng commented 1 month ago

Thank you for sharing your reproduction work. I read your cuda code. I found that your calculations on AABB and center point are different from the author's. Regarding the calculation of AABB, the author has shared his calculation formula, which seems to be a more accurate calculation method. As for the calculation of center point, I initially thought the same as you, that is, to directly use the projection point of the surfel center, but after reading the author's AABB calculation method, I think it is more appropriate to use the AABB center than the surfel projection center, because when the surfel is relatively large, due to perspective projection, the projection point of the surfel may deviate more from the AABB center.

https://github.com/hbb1/diff-surfel-rasterization/issues/8#issuecomment-2138069016

TimSong412 commented 1 month ago

Extremely THANKS for your advice! We are indeed finding bugs in our code. Let me examine it!