TimTeaFan / dplyover

Create columns by applying functions to vectors and/or columns in 'dplyr'.
https://timteafan.github.io/dplyover/
Other
61 stars 0 forks source link

Don't drop the `.` when used in `.names` #5

Open brshallo opened 3 years ago

brshallo commented 3 years ago

I can tell you put a lot of thought into how to handle .names and that figuring out an intuitive way of doing this in the different contexts of {dplyover} is tricky. I was planning on opening a few issues for discussion on potential changes to naming conventions.

But yeah, not sure how to do... just feel maintaining . prefix when specified in .names may be preferred.

TimTeaFan commented 3 years ago

Thanks for opening this issue. When I started working on {dplyover} I built over upon an older version of dplyr::across which still used {col} in the the .names argument. This changed and now {.col} is the recommended way, while {col} still works.

I totally agree that {dplyover} should adapt the naming conventions of {dplyr}. So all functions in the over-across family should use the . prefix. To keep things simple, and because the package is still in an experimental state, I think it would be ok to introduce a breaking change by making the prefix a requirement (and drop support for {x} etc.).