TimUntersberger / nog

A tiling window manager for Windows
MIT License
697 stars 20 forks source link

[RDY] Fix: Registering a keybinding used by another application stops all keybinding registration #200

Closed ramirezmike closed 3 years ago

ramirezmike commented 3 years ago

This addresses the issue where if a keybinding fails nog stops registering keybindings without notifying the user what's happening, which is what issue #198 is about and I suspect what #190 is as well. This was found by binding Jetbrains Toolbox to launch on a keybinding that is configured in nog and then launching nog after the Toolbox application is already running.

To "fix" this I made nog just show a popup explaining the issue and then letting it continue binding other keybindings that it can. I don't think we can take the keybinding from the other application and even if we could I'm not sure if that's user friendly? Idk, maybe if there's a way it could be configurable.

Here's what I have it display

popup