search

TimUntersberger / nog

A tiling window manager for Windows
MIT License
697 stars 20 forks source link

[RDY] Work mode toggle fix #208

Closed ramirezmike closed 3 years ago

TimUntersberger commented 3 years ago

Can you reorganize the project structure like in the custom-language branch? I only need the src folder to be in twm/src. Keeping this branch up to date with upstream is really hard, because I can't use diffs.

Sorry, I should have updated upstream before working on this.

ramirezmike commented 3 years ago

Can you reorganize the project structure like in the custom-language branch? I only need the src folder to be in twm/src. Keeping this branch up to date with upstream is really hard, because I can't use diffs.

Sorry, I should have updated upstream before working on this.

Yeah, no worries. I'll upload something maybe today or tomorrow.

ramirezmike commented 3 years ago

hey @TimUntersberger , I was checking out the custom-language branch and didn't really see the work-mode-toggle code. Did you remove that and was that intentional?

Edit: sorry, nevermind. Literally after I post it I figured it out.

ramirezmike commented 3 years ago

Hey @TimUntersberger

Ok, I found the time to rebase this on the custom-language code and I think it's working right. I had to translate my config files to fit your new changes. One thing is that when I toggle work mode I can't toggle back. I'm looking at the code and I see you've added an "always_active" field on the keybindings instead of explicitly looking for the work mode keybinding. Is that something that the user sets in the config per keybinding?

TimUntersberger commented 3 years ago

One thing is that when I toggle work mode I can't toggle back

There are now two different functions for binding keybindings:

ramirezmike commented 3 years ago

@TimUntersberger

I'm assuming that the custom-language branch is going to be merged into development at some point once it's ready, so I rebased this set of changes onto the custom-language branch. I did notice that the program crashes if you don't have a plugin folder made. I suspect that at some point in the custom-language branch's history it created it correctly prior to some refactoring that introduced this issue. So, this is the work-mode fix + a commit to create the plugin folder if it's missing.

The build is failing on this branch already. If you think this pull request is good, I'm cool with merging this and closing the pull request and addressing the build failure in a separate pull request.

TimUntersberger commented 3 years ago

The CI is failing because of the new project structure.

ramirezmike commented 3 years ago

Ok, I'm merging this into custom-language and going to close #150 noting that it'll be fixed in development branch once custom-language gets merged.