search

TimUntersberger / nog

A tiling window manager for Windows
MIT License
697 stars 20 forks source link

Fix: Re-added swap_columns_and_rows closes #264 #265

Closed ramirezmike closed 3 years ago

ramirezmike commented 3 years ago

This addresses #264

TimUntersberger commented 3 years ago

Did you rebuild the docs?

ramirezmike commented 3 years ago

Did you rebuild the docs?

Right, I ran build_docs.ps1... I recently replaced my OS and reinstalled everything so I'm not sure if it's just an updated version of things but it looks like it made a lot of changes that are like... setting the ID attributes on elements and some differences in the css. Not sure if you want all that in there too? Let me know and I can redo that if needed.

ramirezmike commented 3 years ago

@TimUntersberger

What do you think of the doc generation part of this PR? I have mdbook v0.4.7 installed.. it looks like it made a lot of changes like this

<h1><a class="header" href="#array" id="array">Array</a></h1> to this <h1 id="array"><a class="header" href="#array">Array</a></h1>

where it moves the ID prop from the \ tag to the \

tag. I think it might just be because of some change in mdbook. If you have the same version installed then maybe it's something else that caused it. I just don't want to introduce something that adds a lot of noise and gets done/undone any time someone re-runs the doc gen.

TimUntersberger commented 3 years ago

As long as everything is displayed correctly it should be fine.

ramirezmike commented 3 years ago

Alright.

Also, I'm planning on waiting until your lua branch gets finished and then patching my open PRs rather than like... shoving stuff in that might start causing more confusion for now. It'll be easier that way, I think + might work better with my schedule right now.

ramirezmike commented 3 years ago

Ok, this is an updated version of this PR post-lua changes. I'll merge it in a day or two if no one objects.

TimUntersberger commented 3 years ago

A small tip: if you want to close an issue once this pr is merged you can add closes #264 to the description.