TimUntersberger / nog

A tiling window manager for Windows
MIT License
697 stars 20 forks source link

Refactor from RegisterKeybinding to keyboard hook #283

Closed TimUntersberger closed 3 years ago

TimUntersberger commented 3 years ago

This PR removes the old ugly keybindings manager in favor of an event based system.

After this is merged we can also support windows key for shortcuts and also better differentiate between left and right modifiers.

TODO

ramirezmike commented 3 years ago

Just tested this out, this is super cool.

I quickly glanced over the code and nothing seemed too crazy; I do want to look a little closer at keyboardhook.rs but I might not get to it today.

The one question I have is related to AltGr... am I understanding it correctly that those who have the AltGr key can just bind to "lalt" and everything should just work?