Keybindings don't work reliably or at all in some cases

dmealo commented 4 years ago

Similar to the report in a comment on Reddit, the keybindings are not reliable for me. I am excited about the possibilities with using WWM, but that is making it pretty difficult to use at this point.

Hammster commented 4 years ago

I also can report that I have the same issue, key bindings seam to not work. I tried switching through multiple keyboard layouts in case the identifiers for the keymap enum have been mixed up for the German layout, in total I tried Swedish, German, Cyrillic Montenegro, Hangeul (Korean)

TimUntersberger commented 4 years ago

Could anyone of you please try to run the code with `RUST_LOG="debug,wwm::app_bar=info" and tell me whether you can see any errors and "Registering Keybinding" in the output? I'd like to also know your configs if possible.

I never had problems with the keybindings and i suspect that there is just too little information on my part when something goes wrong. One reason a keybinding might not work, is when another program already has a global keybinding with the same combination of keys.

Hammster commented 4 years ago

烈 Hans  C:\workspace\wwm    master ≣
 $env:RUST_LOG="debug,wwm::app_bar=info"
烈 Hans  C:\workspace\wwm    master ≣
 cargo run
warning: unused manifest key: package.log
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s
     Running `target\debug\wwm.exe`
[2020-06-27T09:18:00Z INFO  wwm] Initializing config
[2020-06-27T09:18:00Z INFO  wwm::startup] Disabled launch on startup in registry
[2020-06-27T09:18:00Z INFO  wwm] Initializing display
[2020-06-27T09:18:00Z DEBUG wwm::display] Taskbar is visible
[2020-06-27T09:18:00Z DEBUG wwm::display] Initialized Display(width: 2560, height: 1440)
[2020-06-27T09:18:00Z INFO  wwm] Initializing taskbar
[2020-06-27T09:18:00Z DEBUG wwm::task_bar] Initialized Taskbar(x: 0, y: 1410, width: 2560, height: 30)
[2020-06-27T09:18:00Z INFO  wwm] Creating tray icon
[2020-06-27T09:18:00Z INFO  wwm] Initializing workspaces
[2020-06-27T09:18:00Z INFO  wwm::app_bar] Creating appbar
[2020-06-27T09:18:00Z INFO  wwm] Registering windows event handler
[2020-06-27T09:18:00Z DEBUG wwm] Workspace is already selected
[2020-06-27T09:18:00Z DEBUG wwm::win_event_handler] Registering win event hook
[2020-06-27T09:18:00Z INFO  wwm] Starting hot key manager
[2020-06-27T09:18:00Z INFO  wwm::hot_key_manager] Registering Keybinding(ALT+CONTROL+W, ToggleWorkMode)
[2020-06-27T09:18:00Z INFO  wwm::app_bar] loading font
[2020-06-27T09:18:00Z INFO  wwm::app_bar] Received paint
[2020-06-27T09:18:00Z DEBUG wwm::event_handler::winevent] Show(false): 'wwm_app_barClosing appbar' | 2229598
[2020-06-27T09:18:00Z DEBUG wwm::event_handler::winevent] FocusChange: 'wwm_app_barClosing appbar' | 2229598
[2020-06-27T09:18:01Z INFO  wwm::app_bar] Received paint
[2020-06-27T09:18:02Z INFO  wwm::app_bar] Received paint
[2020-06-27T09:18:03Z INFO  wwm::app_bar] Received paint
[2020-06-27T09:18:04Z INFO  wwm::app_bar] Received paint

This is what I got, looks like only one key binding as registered ? My config in appdata looks fine though. And I closed any program that may could use global hotkeys,

TimUntersberger commented 4 years ago

Thank you! I think I now know what the problem is. I can now reproduce it.

TimUntersberger commented 4 years ago

@Hammster @DavidMtbg Could you please try the newest commit?

dmealo commented 4 years ago

@TimUntersberger, that commit seems much better in terms of keybindings for me. Float keybinding working now, Split keybinding working now and thus was able to use other features for the first time. Thanks for the update!

Hammster commented 4 years ago

Seams to work for me as well, thanks for the quick fix :)

TimUntersberger / nog

Keybindings don't work reliably or at all in some cases #52