search

TimVincii / Terrastorage

Brings Terraria's amazing storage features to Minecraft!
MIT License
1 stars 0 forks source link

[Suggestion] Expanded Storage Support #1

Closed Pop000100 closed 1 month ago

Pop000100 commented 1 month ago

Description

Quick stack doesn't work with expanded storage I tried 14.1.5

TimVincii commented 1 month ago

Hi! I'll take a look at it and will update you soon.

TimVincii commented 1 month ago

Hi again! just rolled out an update that enhances general compatibility with other mods, it also fixes some of the issues with Expanded Storage, but not all of them.

Quick Stack To Nearby Storages now works with the storages added by Expandeded Storage, but it doesn't work perfectly: By default, when using the Quick Stack to Nearby Storages feature, the entire inventory of a double chest is considered, even if only one half is in the player’s line of sight. However, for double chests whose block entities do not extend LidOpenable, the feature only recognizes the individual inventory of the visible chest block entity. This results in items only being stacked into the visible half of the double chest, instead of the entire inventory

This issue affects all the chests in Expanded Storage, since they were all made from scratch and don't extend LidOpenable, but instead have their own ChestLidController.

I’m committed to fixing this issue in the next version, but in the meantime, you can mitigate it by disabling the line-of-sight check with the command: /terrastorage line-of-sight-check false.

For now, I’ll keep this issue open since Expanded Storage isn't fully compatible yet, but you’re welcome to close it if you prefer. Thank you for the suggestion, and I wish you a great day!

TimVincii commented 1 month ago

Hello again, version 1.0.6 of Terrastorage fixes the final issue regarding Quick Stacking to Nearby Storages with Expanded Storage. However, please note that renaming any of the storage blocks or entities from Expanded Storage remains unsupported, as it is a limitation that would be difficult to overcome, and I prefer focusing on other improvements for now.

With that said, I will be closing this issue as completed. Thank you for your understanding and have a great day!