search

TimWolla / docker-adminer

Database management in a single PHP file
https://hub.docker.com/_/adminer/
157 stars 69 forks source link

Does not include designs from submodules #106

Closed Reintjuu closed 2 years ago

Reintjuu commented 2 years ago

When setting a theme that is included as a submodule in the original Adminer repo (https://github.com/vrana/adminer/tree/master/designs) through ADMINER_DESIGN, Adminer falls back to the original theme. https://github.com/Niyko/Hydra-Dark-Theme-for-Adminer/issues/13 lists a few possible solutions but I think this Dockerfile should include all themes listed in the original repo.

TimWolla commented 2 years ago

Ugh, thanks for the report. I really want to avoid cloning the git repository within my Dockerfile. The GitHub generated archives are just so much easier to consume.

Reintjuu commented 2 years ago

Woah, thanks for the quick reply! If you need help in any way or need a PR review, don't hesitate to ask.

TimWolla commented 2 years ago

@Reintjuu Feel free to have a look at #107. It worked in my tests, but I'm really not happy with that solution.

X1pheR commented 2 years ago

I just faced this problem. Is there still being worked on a solution?

TimWolla commented 2 years ago

@X1pheR Sorry, I lost track of #107. I've created a reminder to look into that once more.

X1pheR commented 2 years ago

Thanks. If it completes, will this issue be updated? I'll just wait then ;)

kaptcha0 commented 2 years ago

I'm still facing this issue, are there any fixes?

TimWolla commented 2 years ago

I'm still facing this issue, are there any fixes?

https://github.com/docker-library/official-images/pull/11984