Current version of Adminer generates warnings under PHP 8 when submitting custom queries

[pospjan]

What was the reason behind PHP update in https://github.com/TimWolla/docker-adminer/commit/e1e324eeeba2c7e061603df365b485d9661902f6? It seems that Adminer isn't fully supporting PHP 8 while doing custom queries:

[TimWolla]

What was the reason behind PHP update

No particular reason, other than not trailing behind PHP releases. There were quite a few PHP 8 fixes and PHP 8 is almost one year old by now, so I assumed that it would be properly supported now.

It seems that Adminer isn't fully supporting PHP 8 while doing custom queries:

Would you mind filing an upstream issue at https://sourceforge.net/p/adminer/bugs-and-features/? I can revert to PHP 7.4 if necessary, but the bug needs to be fixed nonetheless.

[TimWolla]

A similar issue has already been reported upstream as it looks like: https://sourceforge.net/p/adminer/bugs-and-features/801/

[pospjan]

@TimWolla Hi Tim, thanks a lot for such a quick response. I will try to fix this particular Adminer's problem on my own and send a PR to the upstream.

[pospjan]

@TimWolla I've created a pull request to the upstream, so maybe it will be fixed in the near feature - https://github.com/vrana/adminer/pull/442 :)

But still - wouldn't be better to keep this docker image based on php 7.4 as the Adminer seems not to be completely ok with php8? PHP 7.4 will be supported till 28 Nov 2022, so it should be ok from this point of view.

[TimWolla]

see also: https://github.com/TimWolla/docker-adminer/pull/85#issuecomment-936154226

[fractalf]

Having the same issue.

These warnings also come inserted into the .sql export. I was scratching my head for 5 minutes before realizing the docker image had been updated.