search

TimWolla / docker-adminer

Database management in a single PHP file
https://hub.docker.com/_/adminer/
161 stars 70 forks source link

Detect `adminer.css` request by DOCUMENT_URI #62

Closed pepakriz closed 5 years ago

pepakriz commented 5 years ago

Hi,

since this change: https://github.com/vrana/adminer/commit/7f32e2675941bd16f6d2f3c83df1a8c4ed970834 custom css theme file is not served by fastcgi image. It's because REQUEST_URI contains URL query part (adminer.css?v=2379363894) but it should compare just the "document" part (adminer.css).

Are you OK with this solution? DOCUMENT_URI has a little different behavior, see https://stackoverflow.com/questions/39254/whats-the-difference-between-document-uri-and-uri-request-in-ssi

TimWolla commented 5 years ago

LGTM if it does not break the standalone image.

TimWolla commented 5 years ago

Thanks.

TimWolla commented 5 years ago

docker-library/official-images#6878

pepakriz commented 5 years ago

@TimWolla great, thank you!