search

TimWolla / docker-adminer

Database management in a single PHP file
https://hub.docker.com/_/adminer/
161 stars 70 forks source link

mssql support #72

Closed staff0rd closed 4 years ago

staff0rd commented 4 years ago

Per #15

Tested against mcr.microsoft.com/mssql/server on Ubuntu.

Haven't tested against Windows because I cannot run an adminer image built on Windows - presuming it has something to do with line-endings but building after git clone git@github.com:TimWolla/docker-adminer --config core.autocrlf=input didn't work either and fails to run with the following;

standard_init_linux.go:211: exec user process caused "no such file or directory"

Size increase is negligible;

REPOSITORY                       TAG                 IMAGE ID            CREATED             SIZE
adminer-mssql                    latest              9aae71b7801f        21 minutes ago      90.5MB
adminer                          latest              25e1f7ab82e9        About an hour ago   87.7MB
TimWolla commented 4 years ago

Also: Consider rebasing on master / merging in my master. I messed up with my GitHub Actions configuration and they do not run on third party pull requests: https://github.com/TimWolla/docker-adminer/commit/6d58bf03fda453d21166b7a026d95fde12a8edf2

staff0rd commented 4 years ago

updated

staff0rd commented 4 years ago

Updated, tested on MacOS

REPOSITORY                               TAG                 IMAGE ID            CREATED             SIZE
adminer-mssql                            latest              6714e4704d90        34 seconds ago      91.9MB
adminer                                  latest              259cc60bdb72        2 weeks ago         87.7MB
TimWolla commented 4 years ago

Thanks!

TimWolla commented 4 years ago

Oh, one more thing: You forgot to adjust the FastCGI Dockerfile and I also missed it during review. I'll handle this in #74.