search

TimWolla / docker-adminer

Database management in a single PHP file
https://hub.docker.com/_/adminer/
157 stars 69 forks source link

allow custom designs from a https address #82

Closed lalyos closed 3 years ago

lalyos commented 3 years ago

A couple of custom design mentioned at: https://www.adminer.org/#extras are not included like: hydra or pepa-linha-dark. With this change one could use any custom design by adding an env variable like:

ADMINER_DESIGN=https://raw.githubusercontent.com/pepa-linha/Adminer-Design-Dark/master/adminer.css
TimWolla commented 3 years ago

Thank you for your contribution! Besides some technical issues (curl should almost always be invoked as -fsSL) I don't feel like it is a good idea downloading arbitrary data from the Internet when starting the container. The network could be unavailable, a proxy could be required for outgoing HTTP requests or the file could vanish which might or might not prevent the container from starting. Further I strive to provide a stock Adminer experience. That's why I ship exactly the styles that are included in the official repository.

Please add implement in a derived docker image or by bind-mounting a CSS file.

lalyos commented 3 years ago

thanks, I really appreciate your clear explanation. Your points are totally valid, I'll just keep the fork for easy demo purposes...