Closed Nostrademous closed 5 years ago
rebased this PR onto your current HEAD - please merge soon @TimZaman
hmm, i'll look into this one bc locally i am also using gcs (maybe i shouldnt)
rebased around the latest dotaclient and merge-conflicts fixed
I agree with you that if you are locally using GCS this doesn't make sense, but isn't using GCS no longer "local"?
I think its more productive to merge now then maybe fix later if we're unhappy. Preferably we're a bit more smart about this and provide some class that figures out where to save and stuff.
Tested that this indeed runs locally without use of GCP/GCS.
The arg be default is set to False so it should not affect any of the work you are doing.