search

TimZaman / dotaservice

DotaService is a service to play Dota 2 through gRPC
Other
114 stars 19 forks source link

dotaworld unit helper #22

Closed Nostrademous closed 5 years ago

Nostrademous commented 5 years ago

Started to break out Dota2 World functionality that will be useful outside of the examples/client.py file.

TimZaman commented 5 years ago

I think we need to do some design thinking before splitting out of the 1-file paradigm. I really like the single file as it promotes exceptionally fast iteration cycle. As the codebase grows, it allows for ever more (untestable) code and prevents code-reuse.. Do you think we should make a 'pydota' or something submodule?

Nostrademous commented 5 years ago

Well I already own pydota2 and could just remake the repo with dotaservice as a submodule.

Regarding code-reuse - I mean it can happen no matter what you do if developers are lazy. But good documentation and an index to lookup / search for functions should help. Let me think on it, but I think with some dotaservice tweaks we could easily make it two modules