search

TimZaman / dotaservice

DotaService is a service to play Dota 2 through gRPC
Other
118 stars 19 forks source link

Add DotaService Proto for Hero Selection #50

Open Nostrademous opened 5 years ago

Nostrademous commented 5 years ago

We have a way to send Actions to the agent during game time, but we also need a way to inform the hero selection process what heroes we recommend picking.

TimZaman commented 5 years ago

For now, I think we should set up the game with a proto indicating which heroes should be picked on which positions, and how these are controlled. Preferably, that would also allow playing against bots. That means we need to revert the bot_generic.lua mechanism. Right now there's dirty hardcoded bot 0 or bot 5 clause in the lua Think() fn.

Nostrademous commented 5 years ago

I can work on this as I'm familiar with what needs to get done on the Lua side. Since you had stronger opinions than I did on the protobuf structure I opened this issue so you can think and suggest an approach you are comfortable with for agent communication during that phase.

TimZaman commented 5 years ago

I don't think there's a proto that dictates which heroes are picked right?

From the top of my head; we need to specify, somehow: (1) Certain hero picks: (1a) - If we want to control them (1b) - If they should nothing (1c) - If they should be controlled by the default bot [ in which case it cannot overlap with identical heroes that we choose, i think, e.g. how to do a SF vs SF, where one is our bot on radiant, and dire has the builtin default bot?]

On Tue, Feb 5, 2019 at 1:57 PM Nostrademous notifications@github.com wrote:

I can work on this as I'm familiar with what needs to get done on the Lua side. Since you had stronger opinions than I did on the protobuf structure I opened this issue so you can think and suggest an approach you are comfortable with for agent communication during that phase.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TimZaman/dotaservice/issues/50#issuecomment-460819825, or mute the thread https://github.com/notifications/unsubscribe-auth/AHXSRJlxnmwHazm3aBhcy87bDFzXDVctks5vKf4-gaJpZM4akE4g .