Timac / SunCalc

Swift package to calculate the Sun and Moon positions
MIT License
8 stars 3 forks source link

Is it possible to support iOS 15 #2

Open zizicici opened 1 year ago

zizicici commented 1 year ago

Hi, @Timac .

Is Timac/SunCalc possible to support iOS 15, I tried this #1, and I found it is a bad idea. Is there any right way to support iOS 15?

Timac commented 1 year ago

As far as I know, I don’t use any iOS 16 specific APIs so your change in #1 should work. Why was it a bad idea? What did you encounter?

zizicici commented 1 year ago

After using my own branch, although it can run on iOS 15 devices, Xcode 14.3 enters a not-responding state when debugging, which takes a bit longer.

Timac commented 1 year ago

Sounds like an Xcode issue not related to this package

zizicici commented 1 year ago

Thanks for your reply.

// swift-tools-version:5.7
// The swift-tools-version declares the minimum version of Swift required to build this package.

I found the above lines in Package.swift, but I'm not familiar with swift-tools-version.

Are there any official documents about the system version requirements?

Timac commented 1 year ago

The Swift Tools Version is documented here: https://docs.swift.org/package-manager/PackageDescription/PackageDescription.html#

The Swift tools version declares the version of the PackageDescription library, the minimum version of the Swift tools and Swift language compatibility version to process the manifest, and the minimum version of the Swift tools that are needed to use the Swift package. Each version of Swift can introduce updates to the PackageDescription framework, but the previous API version will continue to be available to packages which declare a prior tools version. This behavior lets you take advantage of new releases of Swift, the Swift tools, and the PackageDescription library, without having to update your package’s manifest or losing access to existing packages.

swift-tools-version:5.7 means that Xcode 14.0 or later is required to understand this package.

zizicici commented 1 year ago

Maybe I can reopen that PR?