search

TimboKZ / discord-spoiler-bot

🗣️🛑 Spoiler support for Discord
https://www.npmjs.com/package/discord-spoiler-bot
MIT License
61 stars 19 forks source link

[Suggestion] Put pictures under spoiler #13

Open Plop opened 7 years ago

Plop commented 7 years ago

Hi :)

I just installed the bot, and it's working really great, that's a fantastic bot. I just wanted to know if you're planning to add spoilers for images ? I think that would be a really great feature.

Thanks again

TimboKZ commented 7 years ago

Hey Plop, thanks for the suggestion!

I was thinking about it the other day and I do think it would be quite convenient to have such a feature. The issue at the moment is that converting images into GIFs would be more resource-intensive on the server as opposed to just creating text messages. Also, depending on server bandwidth, images can take too long to download before being deleted and content could still be spoiled.

I'll be looking into possible solutions to that and see what I can do. Until then, I will keep this issue open.

Plop commented 7 years ago

Hey,

I totally understand the reasons, and that seems to be a possible issue. Thanks a lot for your work.

TimboKZ commented 7 years ago

Hello there!

Just finished my exams so I have some free time on my hands. I'm still trying to figure out whether this feature is going to be feasible - can you give me an example use case?

Thinking about it, I believe the spoiler bot is more suitable for occasional spoilers that pop up in conversations - for example, you're talking about trends in TV shows nowadays with a friend and you want to mention that great plot twist you've seen recently. It's just a single spoiler that isn't really a part of a bigger discussion, so spoiler bot can be used here.

For discussions involving many more spoilers, creating a spoiler for every message is tedious so it might be more appropriate to create a separate channel for this kind of discussions. I believe spoiler images fall in the same category, which is why I'm reluctant to add this feature.

Tell me if you'll have any thoughts related to this.

Plop commented 7 years ago

Hey ! :)

Well, seems that there was an update a few days ago, with now this :

NSFW Channels now exist. Please mark your NSFW zones. The explicit content filter will only remove illegal content in these channels.

I had in mind using the spoiler bot to hide images, but we finally can do this by marking a channel as NSFW.

For discussions involving many spoilers, we already had a separate channel (as it would be really annoying to mark every message as a spoiler).

I think that now, your bot is really complete, as Discord added the NSFW Feature, and it is possible to remove the embed for links.

Thanks a lot again :)

Plop commented 7 years ago

Hey again,

Not related to the pictures under spoiler issue.

I do have an issue with the bot, in fact. On the mobile version of Discord, the bot can't hide anything, as the gif is displayed instantly. I don't know if you are able to do anything about that.

TimboKZ commented 7 years ago

Oh yes, I'm aware of that one, it was brought up in #14. Sadly I can't do anything about it and it doesn't seem that Discord for Android allows you turn of auto-play GIFs. I reported the inconsistent behaviour of GIFs across different platforms to Discord devs but I don't think they'll be addressing that issue soon.

robesasu commented 7 years ago

How about that instead of making a spoiler of the picture itself (which could be big), make the spoiler only for the chat thumbnail image? Would that still be resource intensive?

Btw, great bot 👍

TimboKZ commented 7 years ago

Hey @SillyBirds, that is definitely a good way to go about it. Thinking about it again, most of the people self-host the bot anyway so performance isn't a huge issue here and this feature is definitely worth implementing. I might make it disabled by default though, and change the way images are marked.

Perhaps for images we could use spoiler: Topic as the description for the image. Technically I could combine both spoiler text and image in one GIF but it'll be a real pain and probably unreadable if the text is too long. I'm quite busy right now so might not get to implementing this soon but I just reopened this ticket and will come back to it eventually.

Also, thanks for the kind words!

robesasu commented 7 years ago

How about if the target post has both text and an image, to make two separate gif spoilers, with one for each? (with different background colors)

And thanks for replying; take all the time you need.

TimboKZ commented 7 years ago

That sounds like a good idea! I'll keep it in mind once I get to implementing it.