TimeEval / GutenTAG

GutenTAG is an extensible tool to generate time series datasets with and without anomalies; integrated with TimeEval.
MIT License
71 stars 13 forks source link

Custom Input: Add type conversion to float and warning #31

Closed B-Deforce closed 1 year ago

B-Deforce commented 1 year ago

Resolves #30

B-Deforce commented 1 year ago

Should be good now. I implemented and ran the test case and made it more general per your suggestion. Apologies, I'm still kinda new to open-source contributions so had some trouble there... :). Also, I'm using the "Black formatter" so there was some automated formatting done as you'll see.

Let me know if I need to do anything else.

codecov[bot] commented 1 year ago

Codecov Report

Merging #31 (3df9c6b) into main (484d064) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   89.84%   89.87%   +0.02%     
==========================================
  Files          53       53              
  Lines        2078     2083       +5     
==========================================
+ Hits         1867     1872       +5     
  Misses        211      211              
Flag Coverage Δ
unittests 89.87% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gutenTAG/base_oscillations/custom_input.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

CodeLionX commented 1 year ago

Using Black is a good idea.

I think, I will add Black to the project and follow-up with some more test cases.

@B-Deforce thank you for your contribution!