TimeEval / GutenTAG

GutenTAG is an extensible tool to generate time series datasets with and without anomalies; integrated with TimeEval.
MIT License
71 stars 13 forks source link

add existing TS BO #6

Closed gezelligheid closed 1 year ago

gezelligheid commented 1 year ago

One can now add synthetic anomalies to existing univariate TS.

codecov[bot] commented 1 year ago

Codecov Report

Merging #6 (fdbd6dd) into main (0a756c4) will increase coverage by 0.15%. The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   89.57%   89.73%   +0.15%     
==========================================
  Files          52       53       +1     
  Lines        2034     2084      +50     
==========================================
+ Hits         1822     1870      +48     
- Misses        212      214       +2     
Flag Coverage Δ
unittests 89.73% <96.29%> (+0.15%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gutenTAG/utils/compatibility.py 75.00% <ø> (ø)
gutenTAG/utils/default_values.py 100.00% <ø> (ø)
gutenTAG/base_oscillations/custom_input.py 94.59% <94.59%> (ø)
gutenTAG/base_oscillations/__init__.py 100.00% <100.00%> (ø)
gutenTAG/base_oscillations/interface.py 94.20% <100.00%> (+0.35%) :arrow_up:
gutenTAG/base_oscillations/random_walk.py 96.96% <100.00%> (ø)
gutenTAG/consolidator.py 94.73% <100.00%> (+0.19%) :arrow_up:
gutenTAG/generator/timeseries.py 66.36% <100.00%> (ø)
gutenTAG/utils/global_variables.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

CodeLionX commented 1 year ago

@gezelligheid Thank you very much for the effort you put into this PR!

There are still some tests failing. However, I think despite the mentioned minor issues, this PR reached a good state. Let's try to fix the failing tests and type checks and, then, we can merge this into main 👍🏼

You can also run the tests locally:

python setup.py typecheck
python setup.py test
gezelligheid commented 1 year ago

typecheck won't run giving the following message: running typecheck .venv/lib/python3.11/site-packages/numpy/init.pyi:641: error: Positional-only parameters are only supported in Python 3.8 and greater def seek(self, offset: int, whence: int, /) -> object: ... ^ Found 1 error in 1 file (errors prevented further checking)

Which puzzles me as I believe I run 3.11.2

CodeLionX commented 1 year ago

Which puzzles me as I believe I run 3.11.2

This might be the problem and solution likewise. We perform our type checks in Python 3.7 to ensure backwards-compatibility.

CodeLionX commented 1 year ago

Please fix the CI issues.

gezelligheid commented 1 year ago

Thank you for your patience and support @CodeLionX . Is it ok like this?

CodeLionX commented 1 year ago

Thank you for your patience and support @CodeLionX . Is it ok like this?

Yes, this looks like it fixed the typing and test issues. 👍🏼

However, your latest commit 3211be3 also changed the line ending of many files. Please revert to standard \n (LF) line endings for all files!

gezelligheid commented 1 year ago

I forgot to save al CRLF to LF changes before I committed and then corrupted my repo with a reckless bash command. I hope to get to doing it right later today