TimeForANinja / node-ytpl

Anonymous YouTube playlist resolver.

MIT License

203 stars 48 forks source link

fix: Handle empty playlist #122

Open Hazmi35 opened 3 years ago

Hazmi35 commented 3 years ago

This should fix #121

Hazmi35 commented 3 years ago

Should test for empty playlist created too?

TimeForANinja commented 3 years ago

would be cool 😅

codecov[bot] commented 3 years ago

Codecov Report

Merging #122 (d3519ab) into master (fcc26a1) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          260       261    +1     
=========================================
+ Hits           260       261    +1

Impacted Files	Coverage Δ
lib/main.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcc26a1...d3519ab. Read the comment docs.

TimeForANinja commented 3 years ago

i'm also more of a empty array fan since doing that you'd get meta information like playlist title and so on...

Hazmi35 commented 3 years ago

i'm also more of a empty array fan since doing that you'd get meta information like playlist title and so on...

Yes, I didn't think of that before, changed in d3519ab6f1b2929ba1a673191223d5e2bf8f6643.

Do the test still need to be created?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Hazmi35 commented 3 years ago

This should be reopened when you're ready.

TimeForANinja commented 2 years ago

not quite ready but i can at least tell the stale bot to ignore this 😉