search

TimeForANinja / node-ytpl

Anonymous YouTube playlist resolver.
MIT License
203 stars 48 forks source link

Added youtu.be links check and tests #125

Closed th0m4s closed 2 years ago

th0m4s commented 3 years ago

Youtube share links use the youtu.be domain and these were not recognized by the library because the domain was not considered to be a youtube domain.

Here is an example of a share link containing a playlist id: https://youtu.be/hIaYzwf0A8A?list=PL37UZ2QfPUvyeqqNi4m_byAjAbSHBIosW This link is now parsed by the library and tests are updated accordingly.

Thanks in advance!

TimeForANinja commented 3 years ago

thanks for the pr can you also add a test for ytpl.validateID ?

codecov[bot] commented 3 years ago

Codecov Report

Merging #125 (90a4c33) into master (fcc26a1) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          260       260           
=========================================
  Hits           260       260
Impacted Files Coverage Δ
lib/main.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcc26a1...90a4c33. Read the comment docs.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: