TimeForANinja / node-ytsr

Do anonymous YouTube search requests.
MIT License
285 stars 66 forks source link

Stringifying continuation makes it invalid #138

Closed losnappas closed 3 years ago

losnappas commented 3 years ago

Running JSON.stringify on the result object turns Infinity into null, which then gets run against this: https://github.com/TimeForANinja/node-ytsr/blob/master/lib/main.js#L125 .

And funnily enough, (!isNaN(null) && isFinite(null)) === true, so then the continueReq method throws. Let's add a check against null to check it?

TimeForANinja commented 3 years ago

thanks for spotting and reporting 👍 fix merged to git unfortunately can't push it to npm atm

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 3.5.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: