search

TimeForANinja / node-ytsr

Do anonymous YouTube search requests.
MIT License
284 stars 66 forks source link

Catch and log fix #192

Closed TheBrunoRM closed 10 months ago

TheBrunoRM commented 1 year ago

I was getting a EACCES: permission denied error when it tried to create the dump file. I think that it would be better if it would log the error first and then create the dump file, and in case it can't, log the error to the console. This is because if the error appeared when writting the file, it would neither write the file nor log the error.

itsfaraaz commented 1 year ago

hey, any plan on resolving the checks and merging this in? looking to stop the dumps from happening at all.

TheBrunoRM commented 1 year ago

Hello there! I am really sorry as I did not see the messages before. I've gone ahead and made a commit fixing the checks. I hope this helps!

stale[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

TimeForANinja commented 10 months ago

Looks fine to me. I don't personally care about the order, however the try/catch is a good addition. The main Problem is that there is basicaly no way to debug an error without the files and with only the logs.

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 3.8.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: